Cleanup in Abstract_Class_Parser #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1132 +/- ##
=========================================
- Coverage 89.0% 89.0% -0.1%
=========================================
Files 374 373 -1
Lines 19258 19241 -17
=========================================
- Hits 17154 17137 -17
Misses 2104 2104 |
+ For class `c_string_vector`, move member fuction definitions into the `.i.hh` file. This allows the entire helper class to be defined in a single place. Also disable copy/move constructors and assignment/move-assignment operations. + For class `Contextual_Parse_Functor`, move all definitions into to a new `.hh` file. This allows the entire helper class to be defined in a single place. + Re-wrap comment blocks to 100 columns. + Remove doxygen config option that is deprecated by newer versions of doxygen.
KineticTheory
force-pushed
the
cleanup-acp
branch
from
65c06b6 to
38cf55f
Compare
|
@kgbudge Can you look through the C++ changes? I've moved some things around so I can start debugging doxygen parse failures related to these files. |
It looks okay to me. |
kgbudge
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This clean-up includes the removal of classThis class is needed by a client.Contextual_Parse_Functor, since it doesn't appear to be used. I'm not sure if this change is safe, but downstream testing will be required to know if this is the case.Description of changes
c_string_vector, move member fuction definitions into the.i.hhfile. This allows the entire helper class to be defined in a single place. Also disable copy/move constructors and assignment/move-assignment operations.Contextual_Parse_Functor, move member function definitions to the.hhfile. This allows the entire helper class to be defined in a single place.Status