Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order nodes counterclockwise for each face in Draco_Mesh::Layout. #550

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

RyanWollaeger
Copy link
Contributor

Background

  • In 2D, it is simpler to assume rotation-ordered face-node pairing in Draco_Mesh::Layout.
    • For instance, it is easier to determine orientation of a normal vector to a face.
  • Since the X3D and RTT mesh file parsers preserve counterclockwise node ordering in 2D, the generation of the connectivity data (for instance, cell-to-cell linkage) can be made somewhat less computationally complex.

Purpose of Pull Request

  • Keep node ordering in generation of [cell, side, ghost cell]-node vector pairs, where vector is subscripted by cell-local face index (which simplifies generation of mesh connectivity data in 2D).
  • Add some missing comment documentation for functions arguments in Draco_Mesh.cc and X3D_Draco_Mesh_Reader.i.hh
  • Fixes Issue Fix autodoc issues wrt mesh package #524

Description of changes

  • Generate Draco_Mesh Layouts assuming rotation-ordered node pairs.
  • Add missing parameter descriptions needed by autodoc (issue 524).

Status

+ Generate Draco_Mesh Layouts assuming rotation-ordered node pairs.
+ Add missing parameter descriptions needed by autodoc (issue 524).
@RyanWollaeger RyanWollaeger self-assigned this Dec 15, 2018
@RyanWollaeger RyanWollaeger added this to the Draco-7_0_0 milestone Dec 15, 2018
@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #550 into develop will decrease coverage by <.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           develop    #550     +/-   ##
=========================================
- Coverage     93.3%   93.3%   -0.1%     
=========================================
  Files          376     376             
  Lines        17685   17681      -4     
=========================================
- Hits         16504   16500      -4     
  Misses        1181    1181

1 similar comment
@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #550 into develop will decrease coverage by <.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           develop    #550     +/-   ##
=========================================
- Coverage     93.3%   93.3%   -0.1%     
=========================================
  Files          376     376             
  Lines        17685   17681      -4     
=========================================
- Hits         16504   16500      -4     
  Misses        1181    1181

@KineticTheory KineticTheory merged commit 6811836 into lanl:develop Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants