Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink the default variant #475

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Shrink the default variant #475

wants to merge 11 commits into from

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Mar 4, 2025

PR Summary

This is a refactor intended to help with build times, especially on GPUs. A number of EOS's in the default variant are unused by the fortran codes. To my mind, this means they should be removed, as the C++ codes can implement their own variant.

I thus shrink the default variant significantly by removing:

  • The relativistic eos modifier
  • The unit system modifier
  • The StellarCollapse EOS

I also move StiffGas behind the SINGULARITY_USE_V_AND_V_EOS flag.

@rbberger this may help with clang builds. I wanted to split this out from the relocatable-device-code MR because I think they're orthogonal changes and the relocatable device code MR is a bigger change.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@Yurlungur Yurlungur added build Something to do with the build system clean-up Changes that don't affect code execution but make the code cleaner labels Mar 4, 2025
@Yurlungur Yurlungur self-assigned this Mar 4, 2025
@Yurlungur
Copy link
Collaborator Author

Note by shrinking the default variant, I had to remove these modifiers from the Python bindings, because the Python bindings use the default variant.

@Yurlungur
Copy link
Collaborator Author

Note that on my laptop, with clang, this MR shrinks compile times by a factor of 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Something to do with the build system clean-up Changes that don't affect code execution but make the code cleaner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants