-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink the default variant #475
Open
Yurlungur
wants to merge
11
commits into
main
Choose a base branch
from
jmm/shrink-type-list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note by shrinking the default variant, I had to remove these modifiers from the Python bindings, because the Python bindings use the default variant. |
9 tasks
Note that on my laptop, with clang, this MR shrinks compile times by a factor of 2. |
jhp-lanl
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a refactor intended to help with build times, especially on GPUs. A number of EOS's in the default variant are unused by the fortran codes. To my mind, this means they should be removed, as the C++ codes can implement their own variant.
I thus shrink the default variant significantly by removing:
I also move
StiffGas
behind theSINGULARITY_USE_V_AND_V_EOS
flag.@rbberger this may help with clang builds. I wanted to split this out from the relocatable-device-code MR because I think they're orthogonal changes and the relocatable device code MR is a bigger change.
PR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following:
when='@main'
dependencies are updated to the release version in the package.py