HyperMD + react-codemirror

[cgestes]

Hi guys,

Thank you for this awesome project.

As I was saying in #21 I cannot get HyperMD (the typescript version) to work with react-codemirror.

I made a really simple test case to investigate but I couldn't find the issue.

Demo:
https://github.com/cgestes/react-hypermd-demo

Any idea how I can find what is wrong with this demo?

[cgestes]

Please not that switching the mode to gfm works. (using the hypermd-light theme)

[laobubu]

Have you tried mode: "hypermd" ?
If still not working, I'll check it tomorrow

[laobubu]

Looks like react-codemirror 's build has a outdated CodeMirror inside (see https://github.com/JedWatson/react-codemirror/tree/master/dist ), which lacks some features to support HyperMD.

Try setting <ReactCodeMirror>'s prop codeMirrorInstance={ require("codemirror") }

[cgestes]

I'll try and keep you posted, thank you ;)

[cgestes]

Thank you for the leads.

Here are the results:

• setting mode to hypermd doesnt work.
• setting the codemirror instance to codemirror v5.38 doesnt help
• deduplicating codemirror only v5.38 (just in case) doesnt help

(I added to commit to force codemirror version)

Any new ideas?

[cgestes]

Got it to work...

It does work with the npm published version, but not when using yarn link.

[cgestes]

nailed it...

The issue was a duplication of the codemirror instance when using yarn link.

I fixed it by putting codemirror in peerDependencies instead of dependencies.

[cgestes]

I guess we can close this one.

[cgestes]

see #27