Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mouse keybinds #1835

Merged
merged 5 commits into from
Dec 19, 2022
Merged

Implement mouse keybinds #1835

merged 5 commits into from
Dec 19, 2022

Conversation

xDarksome
Copy link
Contributor

@xDarksome xDarksome commented Dec 18, 2022

This PR:

  • generalizes lapce-data/keypress module to be able to handle both keyboard and mouse presses
  • makes MouseForward/MouseBackward/MouseMiddle available to binding (via config and KeyMap UI)
  • wires up those bindings to the Editor widget

The bindings are currently only wired to the Editor widget as it's sufficient for my use case, and I'm not sure whether this feature is needed in other widgets.

  • Added an entry to CHANGELOG.md if this change could be valuable to users

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Merging #1835 (0732024) into master (19cefff) will increase coverage by 0.55%.
The diff coverage is 26.04%.

@@            Coverage Diff            @@
##           master   #1835      +/-   ##
=========================================
+ Coverage    6.39%   6.94%   +0.55%     
=========================================
  Files         128     128              
  Lines       55408   55515     +107     
=========================================
+ Hits         3542    3858     +316     
+ Misses      51866   51657     -209     
Impacted Files Coverage Δ
lapce-data/src/keypress/mod.rs 15.90% <0.00%> (-0.49%) ⬇️
lapce-ui/src/editor.rs 0.00% <0.00%> (ø)
lapce-ui/src/keymap.rs 0.00% <0.00%> (ø)
lapce-ui/src/tab.rs 0.00% <0.00%> (ø)
lapce-data/src/keypress/keypress.rs 73.23% <37.20%> (+60.35%) ⬆️
lapce-data/src/keypress/loader.rs 86.20% <100.00%> (+1.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MinusGix MinusGix added the A-keymap Area: default key bindings label Dec 18, 2022
@dzhou121 dzhou121 merged commit a9eb2d2 into lapce:master Dec 19, 2022
@panekj panekj added this to the Next release milestone Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-keymap Area: default key bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants