custom form #37
Merged
custom form #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screen.Recording.2024-09-27.at.10.11.55.movcustom logo size and correction |
atmonshi
requested changes
Sep 30, 2024
src/Facades/Qr.php
Outdated
| @@ -84,6 +97,7 @@ public static function getFormSchema( | |||
| '9' => '9', | |||
| ]), | |||
|
|
|||
|
|
|||
src/Facades/Qr.php
Outdated
| @@ -146,7 +160,7 @@ public static function getFormSchema( | |||
| ]) | |||
| ->columnSpan(['sm' => 2]) | |||
| ->columns(['sm' => 2]) | |||
| ->visible(fn (Get $get) => $get('hasGradient')), | |||
| ->visible(fn(Get $get) => $get('hasGradient')), | |||
There was a problem hiding this comment.
can you revert the code formatting
src/Facades/Qr.php
Outdated
| @@ -182,21 +196,38 @@ public static function getFormSchema( | |||
| ]) | |||
| ->columnSpan(['sm' => 2]) | |||
| ->columns(['sm' => 2]) | |||
| ->visible(fn (Get $get) => $get('hasEyeColor')), | |||
| ->visible(fn(Get $get) => $get('hasEyeColor')), | |||
There was a problem hiding this comment.
can you revert the code formatting and empty line
src/Facades/Qr.php
Outdated
| ]), | ||
|
|
||
| Placeholder::make('preview') | ||
| ->label(__('Preview')) | ||
| ->columns(['sm' => 2]) | ||
| ->columnSpan(['sm' => 2, 'lg' => 1]) | ||
| ->key('preview_placeholder') | ||
| ->content(fn (Get $get) => Qr::render( | ||
| ->content(fn(Get $get) => Qr::render( |
src/Facades/Qr.php
Outdated
| @@ -210,6 +241,8 @@ public static function getFormSchema( | |||
| public static function output(?string $data = null, ?array $options = null): HtmlString | |||
| { | |||
| $maker = new Generator; | |||
| // $maker->errorCorrection('L'); | |||
There was a problem hiding this comment.
if we added the percentage to the default array we dont need this default variable
src/Facades/Qr.php
Outdated
| if (filled($logo->getPathName())) { | ||
| $maker = $maker->merge($logo->getPathName(), .4, true); | ||
|
|
||
| if ($logo instanceof \Illuminate\Http\UploadedFile && filled($logo->getPathName())) { |
There was a problem hiding this comment.
I am not following this part and why we need it?
if the image loaded from a storage path I dont think we need to upload it again, right?
|
fix #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.