New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: evaluate potential closure value before rendering component #197

Merged

atmonshi merged 1 commit into lara-zeus:3.x from mallardduck:fix-filament-evaluates

Mar 7, 2024

Contributor

mallardduck commented Mar 6, 2024 •

edited

Loading

Fixes #196

The changes were made in this way to match the style of how getExtraFields() is handled. Essentially matching style parity with:

sky/src/Filament/Resources/NavigationResource/Pages/Concerns/HandlesNavigationBuilder.php

Line 122 in 6efe702

    
           ->visible(fn (Component $component) => $component->evaluate(SkyPlugin::get()->getExtraFields()) !== [])


          fix: evaluate potential closure value before rendering component

6ad532e

Member

atmonshi commented Mar 7, 2024

prefect, sorry for the delay.

thank you so much again :)

atmonshi merged commit 90fa533 into lara-zeus:3.x

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet