Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axing persistent decorators #27

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Axing persistent decorators #27

wants to merge 6 commits into from

Conversation

aarongustafson
Copy link

This pull request fixes #22.

@JeffreyWay
Copy link
Collaborator

Hmm - I'm not sure I like the idea of 'undecorate'. I'll see if I can make it reset every time.

@aarongustafson
Copy link
Author

Yeah, I had a hard time coming up with a name :-)

Hmm - I'm not sure I like the idea of 'undecorate'. I'll see if I can make it reset every time.


Reply to this email directly or view it on GitHub (#27 (comment)).

@dimamarkus
Copy link

Hey Jeff,

Do you have any tips on how to run multiple commands with their own decorators in one controller action? It does not seem to be possible. The second command hits the decorators of the first. Please let us know or consider this pull request please.

@MitchellMcKenna
Copy link

@JeffreyWay Would you be okay with clearDecorators() instead of undecorate()?

@aarongustafson Can you update the pull request to fix the merge conflicts (looks like just a comment has changed)? Also, you don't have to do if (count($decorators)) you can just do if ($decorators).

edderrd added a commit to edderrd/Commander that referenced this pull request Nov 10, 2014
edderrd added a commit to edderrd/Commander that referenced this pull request Nov 10, 2014
@ronnievisser
Copy link

I really need this fix? when will it be merged?

@ronnievisser
Copy link

Related to this issue I found another but. when for example foreaching a collection en in that foreach you have a command executed with a decorated the command itself get's multiplied. so first 1 command, second 2 commands, third item 3 commands, etc etc..

@jojovem
Copy link

jojovem commented Dec 4, 2014

+1. I just go into the same problem, will this be fixed?

@aarongustafson
Copy link
Author

I tweaked the method name and the conditional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator error when command is triggering another command
6 participants