Fixes laravel-doctrine/acl#25 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainer] is not instantiable while building [LaravelDoctrine\ACL\RegisterMappedEventSubscribers]
|
@patrickbrouwers issue with HHVM sebastianbergmann/phpunit#1684 seems it need to update PHPUnit |
…eption : Target [Illuminate\Contracts\Auth\Access\Gate] is not instantiable.
|
@patrickbrouwers Can you please merge this PR? It fixes the issue. |
|
Im not involved in this project anymore |
|
Okay, thanks for all your work then! I guess that makes this officially unmaintained. ¯_(ツ)_/¯ |
|
Dunno, there’s more people than just me. Check the LD slack |
|
What if we recruit people to help the package maintenance? |
|
Laravel removed support for HHVM in 5.3 (source). What do you guys think about removing |
|
@eigan Let's remove HHVM and merge this to the 1.1 branch |
|
@remarkusable I have cherry-picked these commits into 1.1. Will remove |
|
Thank you! @mxkh :) Should be available in 1.0.18 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target [Illuminate\Contracts\Container\Container] is not instantiable while building [LaravelDoctrine\ACL\RegisterMappedEventSubscribers]