[Feature] Allow configuration of Faker locale through config #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpslwk
added a commit
to NottingHack/hms2
that referenced
this pull request
Jan 14, 2019
PR is open to fix this laravel-doctrine/orm#362 will have to come back after that is merged and tagged
in line with laravel/framework #17895
eigan
approved these changes
Jun 10, 2019
|
Thank you @dpslwk! :) |
|
Released as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in line with laravel/framework#17895
Since [5.4] Laravel has been able to take the Faker locale form
config(app.faker_locale)In [5.7] laravel/laravel#4785 added the option to the
app/config.php