Add more specific parameter type for setData() method
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FCM message will not be received if array shape is different from array<string, string> (string keys and string values). For example, this code won’t work: ```php return FcmMessage::create() ->setData([ 'string_key1' => 'string_value1', 'string_key2' => 'string_value1', 'string_key3' => 666, // integer value ])->... ``` I propose to specify array shape for the parameter of `setData()` method in order to help IDEs to analyse the code and to highlight possible errors preemptively. This will save developers’ time (I personally spent on this issue a couple of investigation hours).
atymic
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FCM message will not be received if array shape is different from
array<string, string>(string keys and string values).For example, this code won’t work:
I propose to specify an array shape for the parameter of
setData()method in order to help IDEs to analyse the code and to highlight possible errors preemptively. This will save developers’ time (I personally spent on this issue a couple of investigation hours).