Fix for "A message can only have one of the following targets" error

[mgsmus]

https://github.com/kreait/firebase-php/blob/6.x/src/Firebase/Messaging/CloudMessage.php#L75

It checks array keys but does not check if they are empty or not, so it causes "A message can only have one of the following targets: condition, token, topic, unknown" error.

[HAstaShakiba]

please merge this PR.

[mgsmus]

@HAstaShakiba Meanwhile you can use https://github.com/symplify/vendor-patches to patch the error

[veneliniliev]

@atymic please merge this PR

[ZedanLab]

@atymic kindly merge this PR

[veneliniliev]

temporary resolution of the problem...
add "kreait/firebase-php": "6.3.1" to composer.json

[hrep-john]

up

[gabrieldebem]

up

[mtawil]

@atymic Why is this PR taking so long time to merge?

[masterix21]

up

[NViktors]

For real..? PR with such tiny changes takes forever to merge?

[masterix21]

@atymic, could you take a look here? Thanks

[Saifallak]

up @atymic

[la5digital]

👍

[Rignesh-EWW]

any solutions found for this ?

[veneliniliev]

any solutions found for this ?

#116 (comment)

[Rignesh-EWW]

any solutions found for this ?

#116 (comment)

"kreait/firebase-php": "6.3.1"
=> add composer file but not working create the same issue

[masterix21]

If the maintainer doesn't merge the PR, you could use your FcmMessage class to extend the original ones from the last version of the package.

namespace App\Notifications\Concerns;

class FcmMessage extends \NotificationChannels\Fcm\FcmMessage
{
    public function toArray(): array
    {
        $data = [
            'name' => $this->getName(),
            'data' => $this->getData(),
            'notification' => ! is_null($this->getNotification()) ? $this->getNotification()->toArray() : null,
            'android' => ! is_null($this->getAndroid()) ? $this->getAndroid()->toArray() : null,
            'webpush' => ! is_null($this->getWebpush()) ? $this->getWebpush()->toArray() : null,
            'apns' => ! is_null($this->getApns()) ? $this->getApns()->toArray() : null,
            'fcm_options' => ! is_null($this->getFcmOptions()) ? $this->getFcmOptions()->toArray() : null,
        ];

        if ($token = $this->getToken()) {
            $data['token'] = $token;
        }

        if ($topic = $this->getTopic()) {
            $data['topic'] = $topic;
        }

        if ($condition = $this->getCondition()) {
            $data['condition'] = $condition;
        }

        return $data;
    }
}

Then, replace your notifications to use your own FcmMessage like so:

class PushNotification extends Notification
{
    // ...

    public function toFcm($notifiable)
    {
        return \App\Notifications\Concerns\FcmMessage::create();
    }

    // ...
}

[Rignesh-EWW]

=> "A message can only have one of the following targets: condition, token, topic, unknown"

again the same issue generates.

[mwllgr]

Any news here?

[iml885203]

@masterix21 The create function needs to be overridden as well.

namespace App\Notifications\Concerns;

class FcmMessage extends \NotificationChannels\Fcm\FcmMessage
{
    public static function create(): self
    {
        return new self;
    }

    public function toArray(): Array
    {
        $data = [
            'name' => $this->getName(),
            'data' => $this->getData(),
            'notification' => ! is_null($this->getNotification()) ? $this->getNotification()->toArray() : null,
            'android' => ! is_null($this->getAndroid()) ? $this->getAndroid()->toArray() : null,
            'webpush' => ! is_null($this->getWebpush()) ? $this->getWebpush()->toArray() : null,
            'apns' => ! is_null($this->getApns()) ? $this->getApns()->toArray() : null,
            'fcm_options' => ! is_null($this->getFcmOptions()) ? $this->getFcmOptions()->toArray() : null,
        ];

        if ($token = $this->getToken()) {
            $data['token'] = $token;
        }

        if ($topic = $this->getTopic()) {
            $data['topic'] = $topic;
        }

        if ($condition = $this->getCondition()) {
            $data['condition'] = $condition;
        }

        return $data;
    }
}

class PushNotification extends Notification
{
    // ...

    public function toFcm($notifiable)
    {
        return \App\Notifications\Concerns\FcmMessage::create();
    }

    // ...
}

[atymic]

Apologies for the delay, I'm not the maintainer of this specific package and had notifications off. I'll merge shortly, if anyone is interested in joining as maintainer please email me.

[dwightwatson]

@atymic - happy to help out with maintenance. I already look after the APN and Facebook channels as well.