Fix Issue #685: Corrections and Improvements in Model and Migration Generation #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed the logic for determining the table and column names when building foreign key constraints in migrations. - Ensured the correct mapping of table and column names to accurately generate foreign key constraints as specified in the YAML configuration.
- Corrects method naming issues for relationships involving columns with non-standard Laravel naming conventions. - Fixes duplicate method names for multiple relationships to the same table. - Ensures proper handling of foreign key references, including support for Fully Qualified Names (FQNs) and custom relationship names. - Refines logic to avoid method name collisions and respects Laravel's naming conventions.
|
Looks like the build is broken. Not sure if this is your code or existing. Either way, it'd be good to see some tests around the changes you made. |
|
I don't know much about testing and phpunit, but I'll take a look. It's probably just a matter of adapting the tests to the new internal relationship syntax. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the problem reported in issue #685 and includes a series of corrections and enhancements to the generation process for both models and migrations in the Blueprint package.
Key Corrections and Enhancements:
These updates have been tested thoroughly to ensure compatibility and correctness, and we believe they will provide a more robust and predictable experience for Blueprint users.