Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Switch to defineModel in Vue stubs #285

Merged
merged 7 commits into from
Jan 6, 2024
Merged

[1.x] Switch to defineModel in Vue stubs #285

merged 7 commits into from
Jan 6, 2024

Conversation

osbre
Copy link
Contributor

@osbre osbre commented May 28, 2023

@jessarcher
Copy link
Member

I'm excited about defineModel but I think we should keep this as a draft until the feature is no longer marked experimental in Vue.

@laravel laravel deleted a comment from fantomas-code Nov 14, 2023
@osbre
Copy link
Contributor Author

osbre commented Dec 29, 2023

Stable in 3.4: https://blog.vuejs.org/posts/vue-3-4
Will update the PR soon.

@osbre osbre marked this pull request as ready for review December 29, 2023 18:09
jessarcher and others added 3 commits January 2, 2024 11:32
@jessarcher @Jubeki
Restore prop validation and types
74f3db9 
Co-authored-by: Julius Kiekbusch <contact@julius-kiekbusch.de>
@jessarcher
Use model convention from docs
319e70b
@jessarcher
Formatting
2daf054
@jessarcher
Copy link
Member

Thanks @osbre and @Jubeki!

@taylorotwell taylorotwell merged commit 6856cd4 into laravel:1.x Jan 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jubeki Jubeki Jubeki left review comments

@jessarcher jessarcher jessarcher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osbre @jessarcher @Jubeki @taylorotwell