Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Add missing tests for VerifyEmailController to fix up coverage #308

Closed
wants to merge 2 commits into from

Conversation

mortenebak
Copy link

Hi there,

This pull request add the missing tests to the VerifyEmailController, so that the test-coverage reaches 100%. It will be timesaving for others to have this starter kit reach closer to 100% test-coverage.

@mortenebak
Copy link
Author

I can see that continuous-integration/styleci/pr fails. How can I make sure this is fixed on my end?

@mortenebak mortenebak changed the title Add missing tests for VerifyEmailController to fix test coverage Add missing tests for VerifyEmailController to fix up coverage Sep 1, 2023
@driesvints
Copy link
Member

@mortenebak by inspecting the Details link and applying the changes: https://github.styleci.io/analyses/vZ22Qg?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@mortenebak
Copy link
Author

Thanks - thought I had to setup and subscribe to styleci for a moment, even though it would be smarter :)

@mortenebak mortenebak changed the title Add missing tests for VerifyEmailController to fix up coverage [1.x] Add missing tests for VerifyEmailController to fix up coverage Sep 1, 2023
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants