Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): remove redundant @ts-expect-error directives in SSR route setup #434

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

datlechin
Copy link
Contributor

The @ts-expect-error directives were unnecessary for the Ziggy props and location assignments within the global route function, as TypeScript can properly infer these types.

Screenshot 2024-11-02 at 12 38 36

@reyberyturiaga
Copy link

reyberyturiaga commented Nov 3, 2024

To add a bit of context, this issue was introduced by #430. But that PR is failing the automated check for the thing it's trying to fix: https://github.com/laravel/breeze/actions/runs/11384357740/job/31671889124. And indeed, on a fresh install of Laravel Breeze with --react and --typescript flags, the build is failing. Removing @ts-expect-error directives make the build work again.

@taylorotwell taylorotwell merged commit 2c7c669 into laravel:2.x Nov 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants