Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stripe key to Cashier class #642

Closed
driesvints opened this issue Apr 15, 2019 · 0 comments
Closed

Move stripe key to Cashier class #642

driesvints opened this issue Apr 15, 2019 · 0 comments
Milestone

Comments

@driesvints
Copy link
Member

driesvints commented Apr 15, 2019

This method and property in Billable is more of a general purpose setting so it should best be set in the Cashier class. This way all configuration related things are grouped together.

@driesvints driesvints added this to the v10 milestone Apr 15, 2019
@driesvints driesvints changed the title Move getStripeKey call to Cashier class Move stripe key to Cashier class Apr 15, 2019
driesvints added a commit that referenced this issue Apr 15, 2019
This commit sets a fixed Stripe API version for all Stripe API calls made from Cashier. It's being passed as an option to all calls together with the api key. The way options are handled has also been refactored so this is now entirely done on the Cashier class while keeping the Billable entity free from any configuration related options. This may later still be changed when a config file for Cashier is introduced: #531

Closes #621 and #642
driesvints added a commit that referenced this issue Apr 16, 2019
This commit sets a fixed Stripe API version for all Stripe API calls made from Cashier. It's being passed as an option to all calls together with the api key. The way options are handled has also been refactored so this is now entirely done on the Cashier class while keeping the Billable entity free from any configuration related options. This may later still be changed when a config file for Cashier is introduced: #531

Closes #621 and #642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant