[13.x] Fix trialEndsAt more closely represents onTrial #1129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1128
The
trialEndsAt
returns thetrial_ends_at
attribute by default if there are no arguments passed through and the user is indeed on a generic trial. Without theonGenericTrial
check, the function will always returntrial_ends_at
if no arguments were passed through.The
trialEndsAt
function also returnstrial_ends_at
as a fallback because there may be a use case that an application expects a historical date fromtrialEndsAt
.