[13.x] Handle Stripe Object lock timeout #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs on the added method are here: https://stripe.com/docs/rate-limits#object-lock-timeouts |
|
Thanks man. I'll try to take a look at this today. |
|
I haven't gotten to this yet so I'll have to delay this to somewhere next week, sorry. |
|
No stress Dries :) |
|
@kyranb thanks, this looks good to me. Did you confirm that this fixes your issue in production? |
driesvints
changed the title
|
I've only just deployed it to production yesterday. Perhaps it's best to hold off a little bit, and if I don't see any more exceptions then I guess we can assume everything is good. |
|
Hey @kyranb, was this working for you properly? |
|
Haven't seen any exceptions since implementing this 👍 |
driesvints
approved these changes
Oct 8, 2021
|
Thanks @kyranb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for:
#1257
Hasn't been tested, but thought I'd help nevertheless :)