[14.x] New subscription behavior #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
force-pushed
the
new-subscription-behavior-alternative
branch
from
fe8fad9 to
aa679dc
Compare
driesvints
changed the title
driesvints
commented
Aug 16, 2022
| @@ -11,7 +11,19 @@ trait InteractsWithPaymentBehavior | |||
| * | |||
| * @var string | |||
| */ | |||
| protected $paymentBehavior = StripeSubscription::PAYMENT_BEHAVIOR_ALLOW_INCOMPLETE; | |||
| protected $paymentBehavior = StripeSubscription::PAYMENT_BEHAVIOR_DEFAULT_INCOMPLETE; | |||
There was a problem hiding this comment.
This is the main change of this PR.
driesvints
force-pushed
the
new-subscription-behavior-alternative
branch
from
7e0ccf3 to
5b25e0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts the new recommended
default_incompletepayment behavior that Stripe now recommends. The main adjustments here are the transition to the newdefault_incompletevalue when passing thepayment_behaviorwhen creating or updating subscriptions or subscription items and confirming the payment intents server-side before throwing theIncompletePaymentexception.I've extracted the logic to handle payment failures in a new
HandlesPaymentFailurestrait. In here, we'll check if a subscription has a failed payment. If so, we'll check if it needs confirmation and when it does we'll confirm it server-side. If a payment method has been provided as well (usually when creating a subscription) we'll pass it along. After confirming the payment we'll need to update the subscription status. If no confirmation is needed and there is an incomplete payment we'll cascade the exception immediately.I managed to made this PR backwards compatible for existing integrations. Existing integrations are expected to handle failing payments anyway so it should be a smooth upgrade.
The next step I want to take is to update our docs with the flow of how Stripe recommends to handle collecting payment details which is after a subscription has been already created.
More info: https://stripe.com/docs/billing/subscriptions/build-subscriptions?ui=elements#create-subscription