[9.0] Do not update card in createAsStripeCustomer method #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment when using the createAsStripeCustomer method on a Billable entity, it could be that the creation of the customer succeeds but the updating of the card fails. When this happens it's impossible to know which customer was created in Stripe and therefor also impossible to remove this record again when the card update fails. It seems that the updateCard method shouldn't be in the createAsStripeCustomer method as this couples these two API calls too much. If we remove the call from the createAsStripeCustomer method it can be used just for the purpose that it's states. This will always return a Customer object and allow the developer to remove it again if the updateCard method after that fails. This is a breaking change which will require developers to call the updateCard method manually after call the createAsStripeCustomer. I've already adjusted the behavior of the getStripeCustomer call in the SubscriptionBuilder so there's no breaking changes there. You might notice that at the moment the same problem exists for the getStripeCustomer call but at least with these changes the developers have full control to first create the customer and then do a try/catch check around the updateCard method and revert the customer creation if they want. This will require changes to the docs as well which I'll send in as soon as this PR is merged. Fixes #575
driesvints
force-pushed
the
update-customer-methods
branch
from
6d25e2a to
0a0af7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment when using the
createAsStripeCustomermethod on aBillableentity, it could be that the creation of the customer succeeds but the updating of the card fails. When this happens it's impossible to know which customer was created in Stripe and therefor also impossible to remove this record again when the card update fails.It seems that the
updateCardmethod shouldn't be in thecreateAsStripeCustomermethod as this couples these two API calls too much. If we remove the call from thecreateAsStripeCustomermethod it can be used just for the purpose that it states. This will always return aCustomerobject and allow the developer to remove it again if theupdateCardmethod after that fails.This is a breaking change which will require developers to call the
updateCardmethod manually after they callcreateAsStripeCustomer. I've already adjusted the behavior of thegetStripeCustomercall in theSubscriptionBuilderso there's no breaking changes there.You might notice that at the moment the same problem exists for the
getStripeCustomercall but at least with these changes the developers have full control to first create the customer and then do a try/catch check around theupdateCardmethod and revert the customer creation if they want.This will require changes to the docs as well which I'll send in as soon as this PR is merged.
Fixes #575