Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] Fix invoicing subscriptions and extend one off charges #598

Merged
merged 4 commits into from
Dec 17, 2018
Merged

[9.0] Fix invoicing subscriptions and extend one off charges #598

merged 4 commits into from
Dec 17, 2018

Commits on Dec 14, 2018

  1. Tax percentage can be floats as well

    @driesvints
    driesvints committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    d922d85 View commit details
    Browse the repository at this point in the history

  2. Fix invoicing subscriptions 

    When invoicing the customer while swapping plans, Cashier would invoice the customer for all its pending items instead of just the ones for the subscription. This PR fixes this by using the subscription field when creating an invoice to allow swapping a plan and the `incrementAndInvoice` method so the invoice at hand only invoices for the subscription and also uses the proper tax which is applied to the subscription.
    @driesvints
    driesvints committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    3b1d003 View commit details
    Browse the repository at this point in the history

  3. Allow one off invoices to specify extra options 

    When doing one off charges and immediately invoicing them you currently can't add extra options like a tax_percent to it which kind of limits you. By adding this extra option we can pass it to the invoice method with the parameter from the previous commit.
    @driesvints
    driesvints committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    20ed1f6 View commit details
    Browse the repository at this point in the history

  4. Update changelog

    @driesvints
    driesvints committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    8e309b2 View commit details
    Browse the repository at this point in the history