Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] Remove strict type check for trialUntil() #678

Merged
merged 2 commits into from
May 30, 2019
Merged

[9.0] Remove strict type check for trialUntil() #678

merged 2 commits into from
May 30, 2019

Conversation

cmorbitzer
Copy link
Contributor

This removes the type check for a Carbon object in trialUntil() because those using Carbon 2 may also pass a CarbonImmutable object.

@driesvints driesvints changed the title Remove strict type check for trialUntil() [9.0] Remove strict type check for trialUntil() May 29, 2019
driesvints
driesvints requested changes May 29, 2019
View reviewed changes
src/SubscriptionBuilder.php Outdated Show resolved Hide resolved
@taylorotwell taylorotwell merged commit 9dfb4c9 into laravel:9.0 May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmorbitzer @driesvints @taylorotwell