Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Retrieve payment method #800

Closed
wants to merge 3 commits into from
Closed

[10.x] Retrieve payment method #800

wants to merge 3 commits into from

Conversation

tuscan88
Copy link

I've added a method to retrieve a payment method from Stripe by its ID in order to verify that a token is valid. Since the token is generated on the front end it can be manipulated and so I needed a way to validate it in a form request before I attempt to attach it to the customer.

geoffs3310 added 3 commits October 18, 2019 14:40
Add method to retrieve a payment method in order to verify that a token is valid
@driesvints
Copy link
Member

driesvints commented Oct 18, 2019

I don't see the need for this tbh. Just use the PaymentMethod::retrieve from Stripe.

@driesvints driesvints changed the title Retrieve payment method [10.x] Retrieve payment method Oct 18, 2019
@tuscan88
Copy link
Author

That's true of other methods in the Billable trait such as findInvoice but that made it in?

@tuscan88
Copy link
Author

Plus you're already doing the call anyway in resolveStripePaymentMethod but because its protected it's no use to anyone. So I suggest either making that method public or merging this PR in.

@driesvints
Copy link
Member

@geoffs3310 hmm yeah I see your point. Let's try making the existing method public instead.

@driesvints
Copy link
Member

@geoffs3310 I'll send in a new PR for this in a bit.

@driesvints
Copy link
Member

Here: #801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants