[12.x] document the password reset cache
driver
#10534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document laravel/framework#53428
I modeled the wording and organization after the session docs for hopefully a little consistency.
this is a resubmission of #10032. there were a lot of merge conflicts since I had based that off 11.x, so figured it was easier to start fresh.
@taylorotwell you made a comment in that PR about if I could "implement that automatic hashing of the keys so we don't need to worry about prefixes". I could not find any prior reference to that request, and I wasn't exactly sure what you were asking, so I wanted to get some clarification before this is merged.
I think my confusion lies in I'm so used to hashing for passwords via
password_hash()
(non-deterministic) that I forgot there's alsohash()
(deterministic). Are you asking if we could usehash($userEmail)
as our cache key, and then drop the "prefix" completely? I guess that does reduce chance of collision with userland, but does lock it in and force the user to not use that key, where the prefix gives them control. I'm on the fence so I'll defer to you, but I'll document either way.The other thing to be aware of with dropping the "prefix" option now is that the feature has been out for a bit, and we'd likely break some implementations. Given that most expirations shouldn't be too long, I don't think it'd be a huge deal, but definitely something to be aware of.
Reference PRs
laravel/laravel#6487
laravel/framework#53448
laravel/framework#53561