Skip to content

[12.x] document the password reset cache driver #10534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025

Conversation

browner12
Copy link
Contributor

document laravel/framework#53428

I modeled the wording and organization after the session docs for hopefully a little consistency.

this is a resubmission of #10032. there were a lot of merge conflicts since I had based that off 11.x, so figured it was easier to start fresh.

@taylorotwell you made a comment in that PR about if I could "implement that automatic hashing of the keys so we don't need to worry about prefixes". I could not find any prior reference to that request, and I wasn't exactly sure what you were asking, so I wanted to get some clarification before this is merged.

I think my confusion lies in I'm so used to hashing for passwords via password_hash() (non-deterministic) that I forgot there's also hash() (deterministic). Are you asking if we could use hash($userEmail) as our cache key, and then drop the "prefix" completely? I guess that does reduce chance of collision with userland, but does lock it in and force the user to not use that key, where the prefix gives them control. I'm on the fence so I'll defer to you, but I'll document either way.

The other thing to be aware of with dropping the "prefix" option now is that the feature has been out for a bit, and we'd likely break some implementations. Given that most expirations shouldn't be too long, I don't think it'd be a huge deal, but definitely something to be aware of.


Reference PRs

laravel/laravel#6487
laravel/framework#53448
laravel/framework#53561

document laravel/framework#53428

I modeled the wording and organization after the `session.md` docs for hopefully a little consistency.
@browner12
Copy link
Contributor Author

I think this is what you were asking for:

laravel/framework#56127

@taylorotwell taylorotwell merged commit 7fd84ae into laravel:12.x Jul 1, 2025
@browner12 browner12 deleted the AB-cache-password-resets-retry branch July 1, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants