Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Automatic filename generation now uses a different method #2864

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Nov 27, 2016

Resubmit of #2863 with requested change.

@taylorotwell taylorotwell merged commit 749a9be into laravel:master Nov 28, 2016
@browner12
Copy link
Contributor

I believe we should be using 'a UUID' since it is pronounced like 'you' which starts with a consonant sound. We would say 'a user', not 'an user'.

http://www.englishpage.com/articles/a-vs-an.htm

@vlakoff
Copy link
Contributor Author

vlakoff commented Nov 28, 2016

@browner12 Correct. I'm finding numerous sources saying it has to be "a unique". Do you want to submit a PR?

@vlakoff vlakoff deleted the hashName-2 branch December 10, 2016 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants