Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Confirm password #5515

Merged
merged 3 commits into from
Oct 9, 2019
Merged

[6.x] Confirm password #5515

merged 3 commits into from
Oct 9, 2019

Conversation

driesvints
Copy link
Member

Document new password rule and password confirmation functionality.

authentication.md Outdated Show resolved Hide resolved
@arcanedev-maroc
Copy link
Contributor

I was playing with this new feature and i love it a lot 😍

But there is one little thing that bothers me and i need a feedback about it.

I've added the password.confirm middleware to the /home route.

Then when a user create an account, it redirects to the /home page. Password confirm shows up!!

Is it weird to keep it like that for an account created less than auth.password_timeout (3 days by default) or do i need to change the middleware to skip the password confirmation ?

@driesvints
Copy link
Member Author

@arcanedev-maroc this isn't typical something you'd want to add to your home route. Only to some sensitive ones. The password timeout is also three hours by default, not three days.

@arcanedev-maroc
Copy link
Contributor

Yeah, that make sense.

Applying it only in the danger zone 👀

Thanks 👍

@decadence
Copy link
Contributor

to a screen where they need to enter their password before they can continue

How does this screen look like and can we customize it?

@driesvints
Copy link
Member Author

@decadence yes. See laravel/ui#34 and laravel/framework#30214

@taylorotwell taylorotwell merged commit c18929f into laravel:6.x Oct 9, 2019
@driesvints driesvints deleted the confirm-password branch October 9, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants