Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Document app.mix_url customizations #5727

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

paulredmond
Copy link
Contributor

@paulredmond paulredmond commented Jan 16, 2020

Documents app.mix_url implemented in laravel/framework#28952.

I took a stab at the wording, figuring you'd shuffle/rearrange to your liking 😄 . I only documented it in 6.x, but happy to contribute it back to 5.8 as well once you're happy with the wording.

I also noticed this configuration option isn't included with config/app.php out of the box. Is that something you'd like a PR for?

Because:
- This configuration value is undocumented without diving in the source
- Laravel doesn't ship the `mix_url` configuration option with Laravel currently

This commit:
- Adds mix_url to the only section mentioning the `mix()` helper
- Shows examples of using `mix_url`
@driesvints driesvints changed the title Document app.mix_url customizations [6.x] Document app.mix_url customizations Jan 16, 2020
@taylorotwell taylorotwell merged commit 31d5132 into laravel:6.x Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants