Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Suggest asset publishing Composer hook #6230

Merged
merged 9 commits into from
Aug 7, 2020
Merged

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Aug 6, 2020

This PR adds the suggestion of hooking up the telescope:publish and horizon:publish commands to the app's composer.json's post-autoload-dump list. This will make sure that assets are always kept up to date and prevents breakage of the dashboards. This was inspired by Livewire's docs: https://laravel-livewire.com/docs/installation

Added a new "Upgrading Telescope" section to be in line with other first party docs.

I've also moved "Dashboard Authorization" in the Telescope docs one level down to be in sync with Horizon's docs.

@crynobone
Copy link
Member

I normally set it under post-update-cmd since assets would just changed on composer update

Screenshot 2020-08-06 at 6 19 41 PM

I would understand that Livewire might need to republish if a new component is created etc (guessing here).

@driesvints
Copy link
Member Author

driesvints commented Aug 6, 2020

@crynobone does that also work if you, for example, use composer require with the --update-with-dependencies and --update-with-all-dependencies flags?

@crynobone
Copy link
Member

--update-with-dependencies

Screenshot 2020-08-06 at 6 50 20 PM

--update-with-all-dependencies

Screenshot 2020-08-06 at 6 51 20 PM

Yup, both triggered post-update-cmd.

@driesvints
Copy link
Member Author

@crynobone Cool, thanks for verifying 🙂

Update the PR.

horizon.md Outdated Show resolved Hide resolved
telescope.md Outdated Show resolved Hide resolved
@taylorotwell taylorotwell merged commit 2bd28f4 into 7.x Aug 7, 2020
@taylorotwell taylorotwell deleted the asset-updates branch August 7, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants