Document breaking change in password rehashing if custom password field #9901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added missing likelihood-of-impact, which I'm calling "low" since most folks probably use the default 'password' field name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know I'm late to the game with my 11.x upgrade, but I came across what I think is an undocumented breaking change related to the password rehashing. I tested logging in after upgrade and got an exception
Column not found: 1054 Unknown column 'password' in 'field list'. (Which is true - the app I'm upgrading uses a different field name for the password.) Based on the related documentation about theAuthenticatabletrait, I took a closer look at that trait and determined that if I defined$authPasswordNamein my User model it fixed the issue. I adjusted the documentation on this in the upgrade guide to account for this possibility.I also added the missing likelihood-of-impact for this subheading, which I'm calling "low" since most folks probably use the default 'password' field name.