Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed "one-to-many" header on eloquent-relationships page #9922

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Lijahide
Copy link
Contributor

@Lijahide Lijahide commented Oct 1, 2024

added " / Has Many" to the "One to Many" header and corresponding TOC line.

added " / Has Many" to the "One to Many" header and corresponding TOC line.
@Lijahide
Copy link
Contributor Author

Lijahide commented Oct 1, 2024

I was doing some training with a jr programmer and going over the documentation for Eloquent relationships.
We referenced this page many times and the Jr programmer struggled to find the right section for "has many".

I'm not asking you to take responsibility for this isolated problem. But I do think that it helps to add clarifying language to this section; and it certainly does not hurt.
I think it also makes sense to add this change because the "One to Many (inverse) / Belongs To" section already has this clarifying addition.

@taylorotwell taylorotwell merged commit 70abbf2 into laravel:11.x Oct 2, 2024
@Lijahide Lijahide deleted the patch-1 branch October 2, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants