Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] new allowed filename for anonymous index components #9984

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

browner12
Copy link
Contributor

we can now use either index.blade.php or {directory}.blade.php for our anonymous index components.

laravel/framework#52669

we can now use either `index.blade.php` or `{directory}.blade.php` for our anonymous index components.

laravel/framework#52669
@browner12
Copy link
Contributor Author

I chose to omit commenting on the fact the index.blade.php file takes precedence over the directory named file. I went back and forth on it, but it seems like an edge case, and didn't even want to put it in people's heads that they could have both.

open to adding it.

@taylorotwell taylorotwell merged commit c155276 into laravel:11.x Oct 24, 2024
@browner12 browner12 deleted the AB-anonymous-components-filename branch October 24, 2024 15:46
@browner12
Copy link
Contributor Author

i'm down with discouraging the use of index.blade.php, and now we just have consistency across Class based and anonymous components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants