Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not blindly overwrite configuration files #154

Closed
wants to merge 1 commit into from
Closed

do not blindly overwrite configuration files #154

wants to merge 1 commit into from

Conversation

SebastianS90
Copy link
Contributor

closes #153
closes #130

@taylorotwell
Copy link
Member

Instead of all this why not just use a try / finally or something?

@SebastianS90
Copy link
Contributor Author

@taylorotwell try-finally does not always help:

finally.php:

<?php
try {
	sleep(10);
} finally {
	echo "Finally!\n";
}
sebastian@seb-pc ~ % php finally.php 
^C
130 sebastian@seb-pc ~ %

Finally does not execute when pressing Ctrl+C

And finally would not help to preserve a custom phpunit.dusk.xml either. Can you please merge it or point me to a different solution for both bugs?

@SebastianS90 SebastianS90 deleted the do-not-overwrite-config-files branch February 26, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants