Use consistent php binary for running dusk tests #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is always available. Just use it directly in the callback. |
| @@ -46,7 +46,7 @@ public function handle() | |||
| $options = implode(' ', array_slice($_SERVER['argv'], 2)); | |||
|
|
|||
| $this->withDuskEnvironment(function () use ($options) { | |||
| (new Process(trim('php vendor/bin/phpunit -c "'.base_path('phpunit.dusk.xml').'" '.$options), base_path(), [])) | |||
| (new Process(trim(PHP_BINARY . ' vendor/bin/phpunit -c "'.base_path('phpunit.dusk.xml').'" '.$options), base_path(), [])) | |||
There was a problem hiding this comment.
We never use spaces when concatenating.
|
Thanks for this fix @splatEric, I was running into the same error with trying to get setup Codeship. Sorry to hijack the thread, but I was wondering if you could share what steps you are taking to get dusk to run on Codeship now, if you have it working? Are you using artisan to serve the app? I am now getting these errors: |
|
Funnily enough, I wrote up the codeship stuff as well:
https://medium.com/@splatEric/laravel-dusk-on-codeship-e37735af1759?source=linkShare-1f0d75c85096-1485547264
On 27 Jan 2017, at 20:00, Joey Kudish <notifications@github.com> wrote:
Thanks for this fix @splatEric <https://github.com/splatEric>, I was
running into the same error with trying to get setup Codeship.
Sorry to hijack the thread, but I was wondering if you could share what
steps you are taking to get dusk to run on Codeship now, if you have it
working? Are you using artisan to serve the app? I am now getting these
errors:
Curl error thrown for http POST to /session with params
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACVP6PQs0JVnsTA70iJZWfhdMLg8tz0iks5rWky4gaJpZM4Ls2oS>
.
|
|
Thanks a lot @splatEric that's super handy 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to get dusk tests running on codeship, I ran into a problem where the php that was being triggered from the Process was call not consistent with the php binary I was using to run the command. This pull request tackles this by making using of the
PHP_BINARYconstant to use the same version of php.I wrote this defensively as I wasn't sure if there might be circumstances under which the
PHP_BINARYconstant was not set.