This repository has been archived by the owner on Mar 31, 2020. It is now read-only.
Use precision of 10 by default for SASS task #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default in SASS is 5. Bootstrap (bootstrap-sass included with laravel by default) utilizes a `$line-height-base` of `1.428571429`. The default precision rounds this to `1.42857`. This doesn't cause many noticeable issues, but does cause input groups with buttons (`input-group-btn`) to be misaligned. Issue is described [here](twbs/bootstrap-sass#409)
|
In the interim, as a workaround, the code below can be added into elixir.config.css.sass.pluginOptions.precision = 10; |
JeffreyWay
added a commit
that referenced
this pull request
Oct 13, 2015
Use precision of 10 by default for SASS task
|
Thanks! |
|
@JeffreyWay any way this can be merged into 3.0.0? or tag a 3.0.1? |
|
Okay, tagged it just now. You can |
|
awesome, thanks @JeffreyWay |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default in SASS is 5. Bootstrap (bootstrap-sass included with laravel by default) utilizes a
$line-height-baseof1.428571429. The default precision rounds this to1.42857. This doesn't cause many noticeable issues, but does cause input groups with buttons (input-group-btn) to be misaligned. Issue is described here