Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename argument "--tail" to "--follow" #8

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Rename argument "--tail" to "--follow" #8

merged 1 commit into from
Aug 3, 2021

Conversation

pxlrbt
Copy link
Contributor

@pxlrbt pxlrbt commented Aug 2, 2021

To follow the naming of tail I think tail should be renamed as --follow with -f as a shorthand.
What do you think?

@taylorotwell
Copy link
Member

This does follow the naming convention used by the actual "tail" tool.

@pxlrbt
Copy link
Contributor Author

pxlrbt commented Aug 3, 2021

We are talking about the linux command tail, right? Which has the option --follow to keep the logs updating.

When looking at the current docs:
forge daemon:logs is equivalent to tail
forge daemon:logs --tail # Visualize logs in realtime is equivalent to tail --follow

Or did I miss something here?

@taylorotwell
Copy link
Member

Nope - I'm agreeing with you in my comment 😄

@taylorotwell taylorotwell merged commit 52604a4 into laravel:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants