fix empty

laravel · Feb 21, 2023 · 0c6cae0 · 0c6cae0
1 parent edbc590
commit 0c6cae0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/Illuminate/Collections/Arr.php b/src/Illuminate/Collections/Arr.php
@@ -718,6 +718,10 @@ public static function shuffle($array, $seed = null)
             return $array;
         }
 
+        if (empty($array)) {
+            return [];
+        }
+
         $keys = array_keys($array);
 
         for ($i = count($keys) - 1; $i > 0; $i--) {

diff --git a/tests/Support/SupportArrTest.php b/tests/Support/SupportArrTest.php
@@ -860,6 +860,11 @@ public function testShuffle()
         $this->assertTrue($dontMatch, 'Shuffled array should not have the same order.');
     }
 
+    public function testEmptyShuffle()
+    {
+        $this->assertEquals([], Arr::shuffle([]));
+    }
+
     public function testSort()
     {
         $unsorted = [