Proper float comparison in ratio validation (#17963)

laravel · Feb 17, 2017 · 0f5fd5d · 0f5fd5d
1 parent 11d23b7
commit 0f5fd5d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/Illuminate/Validation/Concerns/ValidatesAttributes.php b/src/Illuminate/Validation/Concerns/ValidatesAttributes.php
@@ -478,7 +478,7 @@ protected function failsRatioCheck($parameters, $width, $height)
             [1, 1], array_filter(sscanf($parameters['ratio'], '%f/%d'))
         );
 
-        return $numerator / $denominator != $width / $height;
+        return abs($numerator / $denominator - $width / $height) > 0.000001;
     }
 
     /**