improve test of filter in Collection (#43258)

moharami · web-flow · commit b15dc2ac7e4c · 2022-07-18T10:53:32.000-05:00
If no callback is supplied, all entries of the collection that are equivalent to false will be removed
diff --git a/tests/Support/SupportCollectionTest.php b/tests/Support/SupportCollectionTest.php
@@ -868,6 +868,9 @@ public function testFilter($collection)
         $this->assertEquals(['first' => 'Hello', 'second' => 'World'], $c->filter(function ($item, $key) {
             return $key !== 'id';
         })->all());
+
+        $c = new $collection([1, 2, 3, null, false, '', 0, []]);
+        $this->assertEquals([1, 2, 3], $c->filter()->all());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -868,6 +868,9 @@ public function testFilter($collection)`
`868`	`868`	`$this->assertEquals(['first' => 'Hello', 'second' => 'World'], $c->filter(function ($item, $key) {`
`869`	`869`	`return $key !== 'id';`
`870`	`870`	`})->all());`
	`871`	`+`
	`872`	`+ $c = new $collection([1, 2, 3, null, false, '', 0, []]);`
	`873`	`+ $this->assertEquals([1, 2, 3], $c->filter()->all());`
`871`	`874`	`}`
`872`	`875`
`873`	`876`	`/**`