revert change to float casting

laravel · Jun 24, 2020 · bf3cb6f · bf3cb6f
1 parent 3e7e9b2
commit bf3cb6f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 19 deletions.
diff --git a/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php b/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php
@@ -1178,11 +1178,6 @@ public function originalIsEquivalent($key, $current)
         } elseif ($this->hasCast($key, ['object', 'collection'])) {
             return $this->castAttribute($key, $current) ==
                 $this->castAttribute($key, $original);
-        } elseif ($this->hasCast($key, ['real', 'float', 'double'])) {
-            return bccomp(
-                $this->castAttribute($key, $current),
-                $this->castAttribute($key, $original)
-            ) === 0;
         } elseif ($this->hasCast($key)) {
             return $this->castAttribute($key, $current) ===
                    $this->castAttribute($key, $original);

diff --git a/tests/Database/DatabaseEloquentModelTest.php b/tests/Database/DatabaseEloquentModelTest.php
@@ -148,19 +148,6 @@ public function testCleanAttributes()
         $this->assertFalse($model->isClean(['foo', 'bar']));
     }
 
-    public function testCleanWhenFloatUpdateAttribute()
-    {
-        $original = -16.666347;
-        $new = 20.1 - 36.766347;
-
-        $this->assertFalse($original === $new);
-        $this->assertSame(0, bccomp($original, $new));
-
-        $model = new EloquentModelStub(['castedFloat' => $original]);
-        $model->syncOriginal();
-        $this->assertTrue($model->originalIsEquivalent('castedFloat', $new));
-    }
-
     public function testCalculatedAttributes()
     {
         $model = new EloquentModelStub;
@@ -2005,7 +1992,6 @@ class EloquentModelStub extends Model
     protected $table = 'stub';
     protected $guarded = [];
     protected $morph_to_stub_type = EloquentModelSaveStub::class;
-    protected $casts = ['castedFloat' => 'float'];
 
     public function getListItemsAttribute($value)
     {