Fix warning and deprecation (#50114)

laravel · Feb 16, 2024 · cf95132 · cf95132
1 parent d5a35ef
commit cf95132
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/Illuminate/Support/Str.php b/src/Illuminate/Support/Str.php
@@ -1298,6 +1298,10 @@ public static function headline($value)
      */
     public static function apa($value)
     {
+        if ($value === '') {
+            return $value;
+        }
+
         $minorWords = [
             'and', 'as', 'but', 'for', 'if', 'nor', 'or', 'so', 'yet', 'a', 'an',
             'the', 'at', 'by', 'for', 'in', 'of', 'off', 'on', 'per', 'to', 'up', 'via',

diff --git a/tests/Support/SupportStrTest.php b/tests/Support/SupportStrTest.php
@@ -96,6 +96,8 @@ public function testStringApa()
         $this->assertSame('To Kill a Mockingbird', Str::apa('to kill a mockingbird'));
         $this->assertSame('To Kill a Mockingbird', Str::apa('TO KILL A MOCKINGBIRD'));
         $this->assertSame('To Kill a Mockingbird', Str::apa('To Kill A Mockingbird'));
+
+        $this->assertSame('', Str::apa(''));
     }
 
     public function testStringWithoutWordsDoesntProduceError()