Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update psysh to v0.8 on v5.1 #16773

Closed
d3v2a opened this issue Dec 12, 2016 · 4 comments
Closed

update psysh to v0.8 on v5.1 #16773

d3v2a opened this issue Dec 12, 2016 · 4 comments

Comments

@d3v2a
Copy link

d3v2a commented Dec 12, 2016

  • Laravel Version: 5.1.*
  • PHP Version:all

Description:

many package require nikic/php-parser v3 and on v5.1 we cant install pacakge that need it

v0.8 of psy/psysh support v3 (v5.3 allready support v0.8)

@GrahamCampbell
Copy link
Member

many package require nikic/php-parser v3

Packages should attempt to support multiple versions of php parser instead of just mindlessly upgrading.

v0.8 of psy/psysh support v3 (v5.3 allready support v0.8)

Yeh, though that's technically a new feature, and 5.1 is "LTS". We could technically support it I guess, but we don't want people complaining that stuff broke.

@d3v2a
Copy link
Author

d3v2a commented Dec 12, 2016

psysh is used for tinker so used in dev environment i think there is no problem in production environment

@crynobone
Copy link
Member

psysh is used for tinker so used in dev environment i think there is no problem in production environment

But niche developer might have other requirement to use psysh in their project, which still could cause issues.

@GrahamCampbell
Copy link
Member

I wouldn't recommend starting a project on Laravel 5.1 LTS. It's designed to give slow moving apps bug fixes and security assurance. It's not designed for people to be moving quickly with brand new packages. For these reasons, it's important that we do not brake the 5.1 branch with unneeded upgrades.


Disclaimer, these words are my own, and do not necessarily reflect the views of Taylor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants