Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Moved tinker out to an external package #17002

Merged
merged 1 commit into from
Dec 28, 2016
Merged

[5.4] Moved tinker out to an external package #17002

merged 1 commit into from
Dec 28, 2016

Conversation

GrahamCampbell
Copy link
Member

No description provided.

@JosephSilber
Copy link
Member

What's the motivation behind this?

@GrahamCampbell
Copy link
Member Author

It's dependency heavy, and php-parser conflicts are becoming more and more of an issue for people these days.

@themsaid
Copy link
Member

WHY? 😳

@GrahamCampbell
Copy link
Member Author

The plan is to still have tinker in the default app structure, but it will be removable if people want.

@JosephSilber
Copy link
Member

I can't imagine building a Laravel app without Tinker.

Maybe that's just me.

@GrahamCampbell
Copy link
Member Author

I can't imagine building a Laravel app without Tinker.

Yeh, the idea isn't to remove it from laravel, rather, just make it so that it can be removed, in order to install something else that conflicts with it. This also means that tinker can now be dropped into lumen. :D

@taylorotwell
Copy link
Member

It would be in the default "require" so it would still ship out of the box. It would just be its own component.

@taylorotwell taylorotwell merged commit 180cac1 into master Dec 28, 2016
@GrahamCampbell GrahamCampbell deleted the tinker branch December 28, 2016 16:23
@bobthecow
Copy link
Contributor

php-parser conflicts are becoming more and more of an issue for people these days.

Are they?

@bobthecow
Copy link
Contributor

Oh, like #16773?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants