master composer conflict with orchestral/testbench-core

[iluuu1994]

Laravel Version

13.x-dev (master)

PHP Version

8.2+

Database Driver & Version

No response

Description

Hi! We're testing Laravel in PHPs nightly build. Since the Laravel 13.x branching, we're running into composer conflicts:

https://github.com/php/php-src/actions/runs/13478446360/job/37660589525

 Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - laravel/framework is present at version 13.0.x-dev and cannot be modified by Composer
    - Root composer.json requires orchestra/testbench-core ^10.0 -> satisfiable by orchestra/testbench-core[10.0.x-dev, 10.x-dev].
    - orchestra/testbench-core[10.0.x-dev, ..., 10.x-dev] conflict with laravel/framework <12.0.0 || >=13.0.0.

I see that Laravel currently fixes this by re-setting the version to 12.x-dev.

framework/.github/workflows/tests.yml

Lines 67 to 68 in 50f4319

	- name: Set Framework version
	run: composer config version "12.x-dev"

Bumping vendor versions would be an additional maintenance burden for us, is it possible to avoid this? We've never ran into this issue for previous versions of Laravel. We could switch to the default branch (11.x at this time), although we sometimes catch new errors earlier for development branches.

Thank you!

Steps To Reproduce

git clone https://github.com/laravel/framework.git laravel --branch=master --depth=1
cd laravel
composer install --no-progress --ignore-platform-reqs

[ollieread]

Hi! We're testing Laravel in PHPs nightly build. Since the Laravel 13.x branching, we're running into composer conflicts:

Where are you seeing a 13.x branch?

[iluuu1994]

Master is 13.x, fwiu.

[ollieread]

Master is 13.x, fwiu.

Ah, okay, may bad.

Hey @crynobone, is this something that needs to be fixed on Testbenches side? Because I'd imagine there are many other cases where this will crop up.

[crynobone]

We'll work on this ASAP

[crynobone]

@iluuu1994

It might be best to run tests on the default branch instead of master (Laravel's nightly) branch. I believe you should be able to do:

-git clone https://github.com/laravel/framework.git laravel --branch=master --depth=1
+git clone https://github.com/laravel/framework.git laravel --depth=1

[iluuu1994]

@crynobone Thank you very much!

It might be best to run tests on the default branch instead of master (Laravel's nightly) branch.

Note my previous comment:

We've never ran into this issue for previous versions of Laravel. We could switch to the default branch (11.x at this time), although we sometimes catch new errors earlier for development branches.

If you think it's better to test the default branch, we can do that. However, master changes more frequently and has historically been more useful in uncovering bugs early. That said, if that causes issues for you, we can absolutely switch to the default branch. We'll ping you if this happens again in the next branching phase. 🙂 Thanks again!

[crynobone]

However, master changes more frequently

This is not true for Laravel, PR for master will generally start in Q3 and Q1 (before major release) while default branch will have higher changes throughout the year.

[iluuu1994]

@crynobone Ah ok. Thank you for the hint. This is a misunderstanding on our part then, and we'll switch to the default branch.