[5.2] Issue #11285 - Ability to capitalize translation placeholders #11337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdenFraser
force-pushed
the
issue-11285
branch
2 times, most recently
from
c73d181 to
31b9d09
Compare
| } elseif (strpos($line, ':'.ucfirst($key)) !== false) { | ||
| $line = str_replace(':'.ucfirst($key), ucfirst($value), $line); | ||
| } | ||
|
|
||
| $line = str_replace(':'.$key, $value, $line); |
There was a problem hiding this comment.
It's not possible to do following?
$search = [':'.strtoupper($key), ':'.ucfirst($key), ':'.$key];
$replace = [strtoupper($value), ucfirst($value), $value];
$line = str_replace($search, $replace, $line);There was a problem hiding this comment.
I had realized the strpos() conditionals are pointless overhead (too much Whisky this evening perhaps!) when I saw your comment. That's a much better improvement!
AdenFraser
force-pushed
the
issue-11285
branch
from
31b9d09 to
2a7bda1
Compare
added 2 commits
December 14, 2015 01:39
…translation placeholders for both Validation Rules and Strings
|
@AdenFraser , I suggest add tests for this change. |
|
Probably a wise suggestion actually, will do! |
|
Feel free. |
|
Nice! I do like what this adds, albeit small, its handy. |
|
Great that my proposal made it into core. Could this be backported to a 5.1 maintenance release please? |
|
No, because it's breaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to capitalize translation placeholders for both Validation Rules and Strings.
As suggested in Issue #11285.
The makeReplacements method (on the Translator) and the doReplacements() method (on the Validator) now first check and string replace all capital attributes/placeholders with the same case (all capital) replacement, followed by uppercased attributes/placeholders and finally replacing the lowercase attributes/placeholders as before.