[5.2] Strengthen dealing with null keys

[vlakoff]

Follow-up to #12946.

No behaviour changes, just polishing in order to prevent regressions.

[GrahamCampbell]

please revet that

[vlakoff]

I have changed the other way around, and that's indeed better.

[taylorotwell]

Isn't this how Arr::get already works though? If the key is null it will just return the array?

[thomasruiz]

That's exactly what Arr::get does. https://github.com/laravel/framework/blob/5.2/src/Illuminate/Support/Arr.php#L269

[vlakoff]

Isn't this how Arr::get already works though? If the key is null it will just return the array?

Yeah I've already written this a few times.

It depends if you consider using Arr::get with null key to be a regular use case or on the contrary something to avoid doing if possible. I can keep or remove the relevant commit, your pick.

[taylorotwell]

It's a regular use case. Passing null as the key returns the entire array.

[thomasruiz]

@taylorotwell Ok I see the issue.
When the model is created, attributes and original are both set to an empty array. However, in PHP, $a = []; // (! $a) === true.
I think the PR should add to the first condition in Arr::get: && ! is_array($array), or just replace the condition altogether with that.

[vlakoff]

Still it would be relevant to apply this phpdoc fix.