[5.2] Fix postgres Schema::hasTable();

[themsaid]

As reported in #12856, the current query looks for tables in the information_schema regardless of the TABLE_SCHEMA.

[themsaid]

@GrahamCampbell changing the sql considered breaking? It's a public method. Should I submit to master?

[GrahamCampbell]

Probably fine.

[taylorotwell]

I'm a little confused because "database" is not the same as "schema" in Postgres?

[themsaid]

Yes, this fix searches for the existence of a table in a schema regardless of the database. When you compare Postgres to MySQL, if I'm on MySQL and would like to create a new DB for purpose (x) it's equivalent to creating a new schema in Postgres for the same purpose (x) not a new database.

Maybe this PR is a bit opinionated, if you'd like I can close it and seek a more general solution that allows searching for a table with regards to the schema (and) the database.

Or maybe change the syntax of $table to accept table_name or schema_name.table_name, to make it more obvious that the look up is checking for a table in a schema, not a database in Postgres terms.

What do you think?

[pelim]

@taylorotwell: can this fix also be merged into the laravel 5.1 branch

[taylorotwell]

Please send a PR.

On May 25, 2016, at 4:27 AM, Peter Limbach notifications@github.com wrote:

@taylorotwell https://github.com/taylorotwell: can this fix also be merged into the laravel 5.1 branch

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #13008 (comment)

[GrahamCampbell]

I've backported this to 5.1 for you.

[zogot]

@GrahamCampbell I think that has caused an issue for 5.1

https://github.com/laravel/framework/blob/5.1/src/Illuminate/Database/Schema/Builder.php#L55 Still only passes in 1 parameter to the statement, causing my migrate commands to fail

[GrahamCampbell]

I'll revert the backport on 5.1.

[zogot]

@GrahamCampbell umm might also be an issue in 5.2, since that too only gives 1 parameter. https://github.com/laravel/framework/blob/5.2/src/Illuminate/Database/Schema/Builder.php#L55

The comment in here also details adding schema to the parameters: #12856 but that is also not in 5.2

[GrahamCampbell]

Feel free to send a fix to L5.1 and re-revert my revert if you can fix it.

[GrahamCampbell]

Ping @themsaid.

[zogot]

@GrahamCampbell gosh I'm very sorry, it appears to be an issue on my extension of the Postgres library. The PR does correctly have it. Again very sorry.

[taylorotwell]

Cool, thanks for letting us know.