Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Forget key when key exists #13121

Merged
merged 3 commits into from
Apr 13, 2016
Merged

[5.2] Forget key when key exists #13121

merged 3 commits into from
Apr 13, 2016

Conversation

marcvdm
Copy link
Contributor

@marcvdm marcvdm commented Apr 11, 2016

When using for example ip addresses as keys for an array and try to use array_forget() or Arr::forget() it wil not check if the key exists in the array before exploding the key.

This wil, like Arr::get() or Arr::has(), first check if the key exists.

@GrahamCampbell GrahamCampbell changed the title Forget key when key exists [5.2] Forget key when key exists Apr 12, 2016
@GrahamCampbell
Copy link
Member

Could you add tests please?

@taylorotwell taylorotwell merged commit 1fb37a5 into laravel:5.2 Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants