Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Move base64 decoding to the config component #13290

Closed
wants to merge 3 commits into from
Closed

[5.3] Move base64 decoding to the config component #13290

wants to merge 3 commits into from

Conversation

GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Apr 24, 2016 •
edited
Loading

I've included the commits from #13291 first, to get this to pass.

@taylorotwell
Copy link
Member

I don't think we want to add this check to every single configuration retrieval? :/

@GrahamCampbell
Copy link
Member Author

I think it's ok?

@GrahamCampbell
Copy link
Member Author

Alternatively, I have got another idea...

@taylorotwell
Copy link
Member

Will wait on other idea heh

@GrahamCampbell GrahamCampbell deleted the keys branch April 25, 2016 16:01
@GrahamCampbell
Copy link
Member Author

GrahamCampbell commented Apr 25, 2016 •
edited
Loading

k ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrahamCampbell @taylorotwell