[5.2] Validate Uploaded Image Dimensions

[themsaid]

This PR adds a new validation rule:

// Multiple rules
$rules = ['image' => 'image_dimensions:width=100,min_height=30'];

// Single rule
$rules = ['image' => 'image_dimensions:ratio=3/2'];

Available rules are:

• min_width
• min_height
• max_width
• max_height
• width
• height
• ratio

[bonzai]

eval?

[GrahamCampbell]

yeh, there's no way you need an eval in there

[themsaid]

Yes, I was using it for a different implementation but forgot to change. Will fix.

Sent from my iPhone

On May 4, 2016, at 9:09 PM, Graham Campbell notifications@github.com wrote:

In src/Illuminate/Validation/Validator.php:

•    if (
  

•        isset($parameters['width']) && $parameters['width'] != $width ||
  

•        isset($parameters['min_width']) && $parameters['min_width'] > $width ||
  

•        isset($parameters['max_width']) && $parameters['max_width'] < $width ||
  

•        isset($parameters['height']) && $parameters['height'] != $height ||
  

•        isset($parameters['min_height']) && $parameters['min_height'] > $height ||
  

•        isset($parameters['max_height']) && $parameters['max_height'] < $height
  

•    ) {
  

•        return false;
  

•    }
  

•    if (isset($parameters['ratio'])) {
  

•        list($numerator, $denominator) = array_pad(sscanf($parameters['ratio'], '%d/%d'), 2, 1);
  

•        return eval("return {$numerator}/{$denominator};") == $width / $height;
  

  yeh, there's no way you need an eval in there

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[GrahamCampbell]

np ;)

[taylorotwell]

Guess we'll also need a new language line and docs entry for this.

[themsaid]

Will take care of that in a couple of hours :)